🌱 Fix lifecycle hooks conversions #12507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/runtime-sdk
k8s-ci-robot
added
the
size/L
JoelSpeed
reviewed
Jul 21, 2025
fabriziopandini
added
the
tide/merge-method-squash
sivchari
reviewed
Jul 23, 2025
Member
sivchari
left a comment
sivchari
left a comment
There was a problem hiding this comment.
Thanks!
Overall LGTM, left one nit.
sbueringer
reviewed
Jul 23, 2025
Member
|
Thank you! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: a1a32b94bc931b923b092aab627c6ff518eb2bd2
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Lifecycle hooks are still using v1beta1 objects, but initially we implemented conversion by calling autogenerated conversions func.
Now, after all the work for v1beta2 this is not correct anymore and we have to call the ConverFrom func instead, which also has code to handle "special" conversions like e.g. references
/area runtime-sdk