-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ test/e2e: default to strict field validation & fix unknown field in ClusterClass YAML #12501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ClusterClass Signed-off-by: Stefan Büringer [email protected]
/assign @fabriziopandini @JoelSpeed @sivchari |
/test pull-cluster-api-e2e-main |
/test pull-cluster-api-e2e-main-gke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: ba9b397bd4640ce6092f75e65e36e315b822af4c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-cluster-api-e2e-main e2e-gke is green, this one will fail anyway |
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-cluster-api-e2e-main |
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Before this PR we got warnings in logs if we used unknown fields in our e2e test YAMLs, after this PR the tests will actually fail.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #