Skip to content

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 17, 2025

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Before this PR we got warnings in logs if we used unknown fields in our e2e test YAMLs, after this PR the tests will actually fail.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and sivchari July 17, 2025 10:20
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @JoelSpeed @sivchari

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 17, 2025
@sbueringer sbueringer changed the title ⚠️ test/e2e: default to strict field validation & fix unknown field in ⚠️ test/e2e: default to strict field validation & fix unknown field in ClusterClass YAML Jul 17, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-gke

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba9b397bd4640ce6092f75e65e36e315b822af4c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Jul 17, 2025

/override pull-cluster-api-e2e-main

e2e-gke is green, this one will fail anyway

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

/override pull-cluster-api-e2e-main

e2e-gke Is green, this one will fail anyway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/override pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 79d6f0a into kubernetes-sigs:main Jul 17, 2025
33 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 17, 2025
@sbueringer sbueringer deleted the pr-improve-e2e branch July 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants