-
Couldn't load subscription status.
- Fork 1.4k
⚠️ Align Status fields to optionalfields API conventions #12435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Align Status fields to optionalfields API conventions #12435
Conversation
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
5496147 to
a94ad9b
Compare
|
/test pull-cluster-api-e2e-main |
|
/lgtm In each of these cases, adding MinProperties means we can't do This seems aligned with the intentions of optional fields |
|
LGTM label has been added. Git tree hash: fb960772283c7cc759e928d6c8eb9b963e4820ad
|
|
/lgtm /hold (we are going to merge optionalfields PR in order to minimize conflicts) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10852