Skip to content

Conversation

@sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer added the area/api Issues or PRs related to the APIs label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 1, 2025
@sbueringer sbueringer changed the title ⚠️ Align Status fields to optionalfaields API conventions ⚠️ Align Status fields to optionalfields API conventions Jul 1, 2025
@sbueringer sbueringer force-pushed the pr-optionalfields-status branch from 5496147 to a94ad9b Compare July 1, 2025 20:05
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@JoelSpeed
Copy link
Contributor

/lgtm

In each of these cases, adding MinProperties means we can't do status: {} as this would violate the min properties validation. We therefore need structured clients to not render status: {} in a marshalled object, which is where omitzero will help us.

This seems aligned with the intentions of optional fields

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb960772283c7cc759e928d6c8eb9b963e4820ad

@fabriziopandini
Copy link
Member

/lgtm
/approve

/hold (we are going to merge optionalfields PR in order to minimize conflicts)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit eb08a0c into kubernetes-sigs:main Jul 2, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 2, 2025
@sbueringer sbueringer deleted the pr-optionalfields-status branch July 2, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants