🌱 Set minimum=1 on ObservedGeneration and KubeadmConfig APIEndpoint bindPort #12417
Conversation
…dPort Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/assign @JoelSpeed @fabriziopandini @sivchari |
|
/test pull-cluster-api-e2e-main |
| // bindPort sets the secure port for the API Server to bind to. | ||
| // Defaults to 6443. | ||
| // +optional | ||
| // +kubebuilder:validation:Minimum=1 |
There was a problem hiding this comment.
I assume the 0 value for bind would mean random port and wouldn't be appropriate here?
There was a problem hiding this comment.
Basically if it even works APIserver would bind on a random port (InitConfiguration) and then the later Nodes would try to join on a random port (JoinConfiguration)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 08d5fcde772ca354a244a40fdc6effa78f6b030d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
5 participants
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10852