Skip to content

✨ Adding Addon Provider for cdk8s (CAAPC) to cluster-api #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

✨ Adding Addon Provider for cdk8s (CAAPC) to cluster-api #12332

merged 1 commit into from
Jul 17, 2025

Conversation

PatrickLaabs
Copy link
Contributor

@PatrickLaabs PatrickLaabs commented Jun 9, 2025 •
edited
Loading

What this PR does / why we need it:
With this Pull Request, I'd like to add the Addon Provider for cdk8s to the available lists of Addon Providers for the Cluster-API project.

Link to the Addon Provider CAAPC project:
https://github.com/eitco/cluster-api-addon-provider-cdk8s

Which issue(s) this PR fixes:
Fixes #12330

/area documentation
/area clusterctl

@k8s-ci-robot
Copy link
Contributor

@PatrickLaabs: The label(s) area/area/documentation, area/area/clusterctl cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
With this Pull Request, I'd like to add the Addon Provider for cdk8s to the available lists of Addon Providers for the Cluster-API project.

Which issue(s) this PR fixes:
Fixes #12330

/area area/documentation
/area area/clusterctl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @PatrickLaabs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2025
@PatrickLaabs
Copy link
Contributor Author

/retest

@sbueringer sbueringer added the area/clusterctl Issues or PRs related to clusterctl label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jun 10, 2025
chrischdi
chrischdi reviewed Jun 11, 2025
View reviewed changes
cmd/clusterctl/client/config/providers_client.go Outdated
const (
HelmAddonProviderName = "helm"
FleetAddonProviderName = "rancher-fleet"
Cdk8sAddonProviderName = "patricklaabs-cdk8s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: We have trouble with providers being unmaintained. Could this be transfered to an org instead so ownership can be transitioned if needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrischdi,
that would be definitely a plan for the future. I am currently researching, what needs to be done, to move it to the kubernetes-sigs org 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @chrischdi , any idea on how to move this forward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi We have moved the provider to our organisation 👍

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 993a578b56b2d4fc0a7cb717712b5fcef1e6e2b8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7b5d4b0 into kubernetes-sigs:main Jul 17, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 17, 2025
@PatrickLaabs PatrickLaabs mentioned this pull request Aug 8, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi chrischdi left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

✨ Adding Addon Provider cdk8s

5 participants

@PatrickLaabs @k8s-ci-robot @richardcase @sbueringer @chrischdi