Skip to content

Improve API around machine deletion strategy #7021

@fabriziopandini

Description

@fabriziopandini

User Story

As a user, I would like to have a clean and simple API for configuring machine deletion strategy

Detailed Description

In recent version we expanded MachineSpec with fields allowing us to configure machine deletion strategy, nodeDeletionTimeout, nodeDrainTimeout and also volumeDetachTimeout (#6413); there are also annotations allowing to enable/disable one of the machine deletion steps, like e.g machine.cluster.x-k8s.io/exclude-node-draining

Last but not least we have more requests in the pipeline, like e.g. the request for adding support for DaemonSet eviction when draining nodes

This ticket is about discussing how to normalize the API surface for machine deletion strategy by (some ideas):

  • create a struct that groups all the flags related to this topic
  • introduce a more explicit way to enable/disable one of the machine deletion steps vs using annotations

/kind api-change
/triage accepted

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APIpriority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions