-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add ability to configure mTLS on LBC webhook #4342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/config/runtime_config.go
Outdated
| config.ClientCAs = caCertPool | ||
| config.ClientAuth = tls.RequireAndVerifyClientCert | ||
| }) | ||
| fmt.Println("Configured Kubernetes CA!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget to delete?
| flagWebhookCertDir = "webhook-cert-dir" | ||
| flagWebhookCertName = "webhook-cert-file" | ||
| flagWebhookKeyName = "webhook-key-file" | ||
| flagKubernetesCaPemFilepath = "kube-ca-pem-filepath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a request for this flag? i am curious when users want to configure it on webhook
|
/approved |
|
/lgtm |
Description
Gives users the ability to configure mTLS on the LBC webhooks.
Tested out by mounting the kube ca cm to my lbc pod:
Verified that when Kube API is not configured to present cert, the webhook fails:
When Kube API is configured to present cert, the webhook passes:
When no cert is configured with the LBC, things work either way (cert or no cert):
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯