-
Notifications
You must be signed in to change notification settings - Fork 28
tidy up build and make configs #88
Conversation
Tidy up some minor nits now that the cloudbuild is working. Signed-off-by: Blaine Gardner <[email protected]>
|
Hi @BlaineEXE. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It seems that most images with docker assume they are connected to the host's docker.sock, but that is explicitly not allowed for Prow. I think possibly the build test is best achieved by still using the gcb-docker-gcloud image but using the /buildx-entrypoint directly rather than calling |
|
/retest |
1 similar comment
|
/retest |
Tidy up some minor nits now that the cloudbuild is working.