Skip to content

feat: migrate PVCViewer Controller test-related workflows to notebooks-v1 branch #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: notebooks-v1
Choose a base branch
from
Open

feat: migrate PVCViewer Controller test-related workflows to notebooks-v1 branch #601

wants to merge 5 commits into from

Conversation

noalimoy
Copy link

feat: migrate PVCViewer Controller test-related workflow to notebooks repo

  • Add integration test workflow with Kind cluster setup
  • Add multi-arch build test for AMD64, ARM64, PPC64LE platforms
  • Add unit test workflow with Go test coverage
  • Include testing infrastructure scripts for cert-manager and Istio

This migration enables for PVCViewer Controller tests to run within the notebooks repository.

related: #592

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 18, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Sep 18, 2025
@google-oss-prow google-oss-prow bot added area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 size/L labels Sep 18, 2025
@noalimoy noalimoy force-pushed the feature/migrate_pvcvc_tests_to_notebooks branch from f982f82 to fb652af Compare September 18, 2025 12:23
andyatmiami
andyatmiami suggested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions - changes I am requesting are hopefully obvious/straightforward...

also please be aware - depending on which notebooks-v1 workflow PR is ready to merge first - we may also need a rebase as some of the testing/gh-actions files are also being created in additional PRs being raised.

@noalimoy
Copy link
Author

Hey @andyatmiami
Sorry, I should have opened this PR on the WIN status :) this was my mistake
And regarding the comments from README file, this was automatically added by the AI as part of the PVCViewer changes, to create a trigger for the GitHub Actions I set up.
I still have a few things to finish, so it’s not ready for review yet..

@noalimoy noalimoy marked this pull request as draft September 21, 2025 09:27
@noalimoy
feat: migrate PVCViewer Controller CI workflows to notebooks repo
1df4177 
- Add integration test workflow with Kind cluster setup
- Add multi-arch build test for AMD64, ARM64, PPC64LE platforms
- Add unit test workflow with Go test coverage
- Include testing infrastructure scripts for cert-manager and Istio

This migration enables unified CI/CD for PVCViewer Controller within the notebooks repository structure.

Signed-off-by: noa limoy <[email protected]>
@noalimoy noalimoy force-pushed the feature/migrate_pvcvc_tests_to_notebooks branch from fb652af to 1df4177 Compare September 28, 2025 13:57
@noalimoy
Update pvcviewer_controller_test.go
4b74cbe 
Signed-off-by: Noa Limoy <[email protected]>
@noalimoy
Update README.md
db91f6a 
Signed-off-by: Noa Limoy <[email protected]>
@noalimoy
Update README.md
fdc0111 
Signed-off-by: Noa Limoy <[email protected]>
@noalimoy
Revert README.md
54e91bf 
Signed-off-by: Noa Limoy <[email protected]>
Signed-off-by: noa limoy <[email protected]>
@noalimoy noalimoy force-pushed the feature/migrate_pvcvc_tests_to_notebooks branch from a61be45 to 54e91bf Compare September 28, 2025 14:38
@noalimoy noalimoy marked this pull request as ready for review September 28, 2025 14:46
andyatmiami
andyatmiami approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified workflows run as desired on my fork:

ℹ️ While there has been some discussion on _multi_arch_test workflow in relation to JWA component migration in Slack - those issues don't seem to affect pvcviewer-controller - so for the time being I'm comfortable leaving this unchanged.

@google-oss-prow google-oss-prow bot added the lgtm label Sep 29, 2025
@andyatmiami
Copy link
Contributor

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

@TobiasGoerke TobiasGoerke Awaiting requested review from TobiasGoerke

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

1 more reviewer

@andyatmiami andyatmiami andyatmiami approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andyatmiami andyatmiami

Labels
area/ci area - related to ci area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/L
Projects
Kubeflow Notebooks
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noalimoy @andyatmiami