-
Notifications
You must be signed in to change notification settings - Fork 65
ci(ws): run client generator on frontend PR check #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Guilherme Caponetto <[email protected]>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hi @thesuperzapper , although this is related to the frontend, because of the directory of the changed file, we might need your approval as well, if you could take a look please. Thanks! |
@caponetto @paulovmr @harshad16 @andyatmiami we were discussing this in the meeting today, and came to the concusion that this is probably the best of the options (that is, allowing the frontend devs to explicitly choose which commit of the swagger json to generate from). This was because:
The main question is when and who should be updating the generator commit:
Either way, this is an improvement from the current situation, so we can merge. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
related: #499
This PR updates the CI pipeline for the frontend workspace to fail if there are uncommitted changes in generated code. This helps ensure that all generated files are properly committed and that CI reflects the actual state of the codebase.
Note: The
fetch-depth: 0
argument is required to fetch the full Git history, allowing us to retrieve the specific Swagger version referenced by the commit hash in the swagger.version file.