NodeJs v8 stream.push() after EOF

[Eldar-X]

After upgrade to v8 i got error in console

Error: stream.push() after EOF at readableAddChunk (_stream_readable.js:227:30) at Gzip.Readable.push (_stream_readable.js:195:10) at Gzip.Transform.push (_stream_transform.js:151:32) at Zlib.callback (zlib.js:430:16)

[tuananh]

Confirmed. I get this issue with Node v8 as well.

[tuananh]

Anyone taking this? Can someone point me to where I should look?

[tuananh]

Notice node 8.1 fixes something in zlib. Is this related?

A regression in the Zlib module that made it impossible to properly subclasses zlib.Deflate and other Zlib classes has been fixed. [6aeb555cc4] #13374.

[andykant]

This still occurs in Node v8.1.0.

[niftylettuce]

Same issue, v8.0.0

[tuananh]

@jonathanong could you please take a look?

[jonathanong]

i've seen this before. i haven't investigated it yet. it is one of the blockers for me to upgrading to node 8.

[tuananh]

anyone found a fix for this? also, is there an alternative middleware?

[Eldar-X]

In my case, i found solution by changing order of compress and conditional-get middleware

    app.use(compress({
      flush: require('zlib').Z_SYNC_FLUSH
    }))
    .use(conditional())
    .use(etag())

[jonathanong]

is it because you are using Z_SYNC_FLUSH? what happens if you don't use a flush parameter?

[jonathanong]

e50d15f seems okay to me.

anyone else have any ideas?

[Eldar-X]

@jonathanong without flush parameter i have same result but if koa-compress middleware over conditional-get middleware everything okay. Looks like this issue happening only when we use conditional-get middleware.

[jonathanong]

okay, i think the time i saw this error was with v8.0.0. i don't see it anymore with the latest node

[tuananh]

It seems 8.1.2 fixes it. Any idea what causes this in the first place?

[pastelsky]

Still experiencing this in 8.1.2. I don't have conditional-get middleware.