Skip to content

Conversation

Ahtaxam
Copy link
Contributor

@Ahtaxam Ahtaxam commented Apr 21, 2023

No description provided.

Copy link

@ayushchauhan101 ayushchauhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to replace var and use const or let.

@Ahtaxam
Copy link
Contributor Author

Ahtaxam commented Jun 18, 2023

@ayushchauhan101 made changes. please take a look

@ashokdey
Copy link
Member

A lot can be improved in the code also a few edge cases can be added. I am approving it for now and adding an issue for improvement.

Thanks for the contributions @Ahtaxam and @ayushchauhan101

@@ -0,0 +1,39 @@
var threeSum = function(nums) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we can add the problem statement as a comment.

@ashokdey ashokdey merged commit d62e62c into knaxus:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants