Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Oct 5, 2025

Changes

  • 🧹 Remove the use of old go scaffolding with pack builder

/kind cleanup
Fixes #3005

@knative-prow
Copy link

knative-prow bot commented Oct 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 5, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from dsimansk October 5, 2025 13:49
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2025
@knative-prow knative-prow bot requested a review from nainaz October 5, 2025 13:49
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2025
@gauron99 gauron99 removed request for dsimansk and nainaz October 5, 2025 13:49
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.02%. Comparing base (deff3bf) to head (95e3b3a).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   63.12%   62.02%   -1.10%     
==========================================
  Files         150      162      +12     
  Lines       13227    16905    +3678     
==========================================
+ Hits         8350    10486    +2136     
- Misses       3916     5218    +1302     
- Partials      961     1201     +240     
Flag Coverage Δ
e2e-tests 44.72% <77.77%> (+3.30%) ⬆️
integration-tests 56.77% <44.44%> (+0.14%) ⬆️
unit-tests 45.47% <33.33%> (-4.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 changed the title feat: use upstream scaffolding for go [WIP]feat: use upstream scaffolding for go Oct 5, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 5 times, most recently from c52d5e4 to b4a4209 Compare October 8, 2025 07:22
@gauron99 gauron99 closed this Oct 8, 2025
@gauron99 gauron99 reopened this Oct 8, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 2 times, most recently from 535b772 to ba44af4 Compare October 12, 2025 07:01
@gauron99 gauron99 closed this Oct 12, 2025
@gauron99 gauron99 reopened this Oct 12, 2025
@gauron99 gauron99 closed this Oct 12, 2025
@gauron99 gauron99 reopened this Oct 12, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 4 times, most recently from 14a8c20 to 460913a Compare October 14, 2025 09:53
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2025
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 19, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 2 times, most recently from 1acbe43 to 75f3f39 Compare October 21, 2025 16:40
@gauron99 gauron99 closed this Oct 23, 2025
@gauron99 gauron99 reopened this Oct 23, 2025
@gauron99 gauron99 closed this Oct 23, 2025
@gauron99 gauron99 reopened this Oct 23, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2025
@gauron99 gauron99 closed this Nov 2, 2025
@gauron99 gauron99 reopened this Nov 2, 2025
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2025
@gauron99 gauron99 closed this Nov 10, 2025
@gauron99 gauron99 reopened this Nov 10, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@gauron99
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire our custom go buildpacks + scaffolding

2 participants