-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: mobile navigation title visibility remove the custom double nav implementation #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: mobile navigation title visibility remove the custom double nav implementation #6503
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: codeEvolveZenith345 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d99fd85 to
faee34a
Compare
92468e0 to
b6006d1
Compare
|
/retest |
|
@codeEvolveZenith345: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cf778ee to
6015867
Compare
|
Hi @evankanderson |
|
Hi @dprotaso Please review it and suggest modifications... |
Signed-off-by: codeEvolveZenith345 <[email protected]>
00f9eeb to
b9d9ffa
Compare
Can you clarify your question? FYI - I see the nav now on the home page properly. But this change doesn't seem to fix the original linked issue. eg. navigating to https://deploy-preview-6503--knative.netlify.app/docs/ and then scrolling to the bottom replace |
|
I'm not to familiar with how to fix this - unsure if @evankanderson knows |
Yeah, I actually misunderstoof the context of "double nav" for now I will draft this PR and open it once I have made the actual fix. |
Fixes #6328
Proposed Changes
This PR removes the custom double nav bar implementation and properly utilizes Material for MkDocs' native
navigation.tabsfeature, as recommended by @evankanderson.Changes Made
overrides/partials/header.html: Removed hardcoded navigation tabs (lines 97-119) that created the double nav bardocs/stylesheets/extra.css: Added mobile-specific CSS fixes to ensure site title remains visible during scroll on mobile devicesKey Improvements
Before/After
Before (Mobile):
Screen.Recording.2025-11-15.164828.mp4
After (Mobile):
Screen.Recording.2025-11-15.165038.mp4