Skip to content

Conversation

@kahirokunn
Copy link
Member

Changes

  • 🎁 Add Envoy Gateway install instructions to README

/kind documentation

Fixes #

Release Note

Add Envoy Gateway installation docs

Docs

N/A

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation labels Nov 7, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso and skonto November 7, 2025 05:44
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.45%. Comparing base (b658b58) to head (62bf6e7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   76.45%   76.45%           
=======================================
  Files          17       17           
  Lines        1253     1253           
=======================================
  Hits          958      958           
  Misses        261      261           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn kahirokunn marked this pull request as ready for review November 7, 2025 06:19
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@kahirokunn kahirokunn changed the title docs: Add Envoy Gateway install section WIP docs: Add Envoy Gateway install section Nov 7, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2025
@kahirokunn kahirokunn changed the title WIP docs: Add Envoy Gateway install section docs: Add Envoy Gateway install section Nov 9, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2025
@kahirokunn
Copy link
Member Author

@dprotaso Hello! I'd be grateful if you could leave a review when you have a moment! 🙏

function setup_envoy_gateway() {
kubectl apply --server-side -f https://github.com/envoyproxy/gateway/releases/download/${ENVOY_GATEWAY_VERSION}/install.yaml
# Install Envoy Gateway via Helm with GatewayNamespace deployment to align Service namespaces
helm repo add envoyproxy https://charts.envoyproxy.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to do this without helm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- class: eg-external
gateway: eg-external/eg-external
service: envoy-gateway-system/knative-external
service: eg-external/knative-external
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting - did they change where services are created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Envoy Gateway now has a new feature where it creates Services and Deployments in the Gateway resource's Namespace and assigns OwnerReferences.
This is the same implementation as many other Gateway controllers.
To utilize this, the following values are required:

third_party/envoy-gateway/helm/values-eg.yaml

I believe that using the GatewayNamespace is the best configuration, so I used Helm this time. What are your thoughts on this, @dprotaso ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry was at kubecon back now.

I'm wondering if we can keep the old installation and just remove the explicit overrides we have in EnvoyProxy etc in the external.yaml and internal.yaml file

namespace: envoy-gateway-system

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall before that the name of the svc and namespace wasn't predictable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though if we do that change then it might break upgrades which makes everything more complex.

Actually checking now we don't release the envoy yamls as part of the release so maybe we're ok in terms of what backwards compatibility we support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear you were at KubeCon. I heard there were many exciting announcements this year, so I’m honestly a bit jealous you could attend.

With the namespaces separated in this way, the names of the created Services (and related resources) become fully predictable. Since we are not currently publishing the Envoy YAMLs as part of the official release artifacts, my feeling is that it would be better for the community if we focus less on backward compatibility here and instead present a clear best-practice configuration from the start.

What do you think about taking this approach?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we focus less on backward compatibility here and instead present a clear best-practice configuration from the start.

Yeah I'm good with that approach

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still drop helm and just apply the single yaml file :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso
I've completed it. Cloud you review again? 🙏

Co-authored-by: Dave Protasowski <[email protected]>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2025
@kahirokunn kahirokunn force-pushed the add-eg-doc branch 2 times, most recently from 17592b6 to 9e4c1e1 Compare November 21, 2025 04:27
@knative-prow knative-prow bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 21, 2025
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants