Skip to content

Conversation

jaybuidl
Copy link
Member

Typescript files were not linted by the pre-commit hook.

Two major changes:

  • VS Code is going to use the top-level .prettierrc.json so it may affect the web and subgraph packages.
  • The precommit hook does not run eslint anymore for .js files, only prettier.

What do you think? @alcercu @AndreiMVP

@jaybuidl jaybuidl requested review from AndreiMVP and alcercu June 17, 2022 17:56
@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 308eb1f
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/62b0fe3a894e280009313bf5
😎 Deploy Preview https://deploy-preview-93--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaybuidl jaybuidl self-assigned this Jun 17, 2022
@jaybuidl jaybuidl added this to the prealpha-3 milestone Jun 17, 2022
@alcercu
Copy link
Contributor

alcercu commented Jun 20, 2022

hey @jaybuidl!
Just checked and vim is getting the prettier config from the web directory, so no problem on that side. I don't know about VSCode though.
Regarding the pre-commit hook for typescript files, if it's also intended for the web package, we should have the file extension tsx in the rules too.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 308eb1f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl
Copy link
Member Author

jaybuidl commented Jun 20, 2022

we should have the file extension tsx in the rules too.

Added, @alcercu

@jaybuidl jaybuidl merged commit 0eb43e0 into master Jun 21, 2022
@jaybuidl jaybuidl deleted the chore/linters branch June 21, 2022 15:25
@jaybuidl jaybuidl restored the chore/linters branch November 24, 2022 02:59
@jaybuidl jaybuidl deleted the chore/linters branch November 24, 2022 03:07
Params10 pushed a commit that referenced this pull request Feb 3, 2023
chore: fixed the linters configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Toolchain ⚒️ Build tools configuration, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants