Skip to content

Conversation

@jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Dec 27, 2023

PR-Codex overview

This PR focuses on adding functionality to delay stake changes in the SortitionModule contract.

Detailed summary

  • Added delayedStake struct to store delayed stake changes
  • Added executeDelayedStakes function to execute delayed stake changes
  • Updated tests for stake increase and decrease with delayed stakes

The following files were skipped due to too many changes: contracts/test/arbitration/staking.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 9c1ef81
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/658c66b551475c00083fe38a
😎 Deploy Preview https://deploy-preview-1381--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaybuidl jaybuidl added this to the testnet-3 milestone Dec 27, 2023
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 9c1ef81 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 8

View more on Code Climate.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jaybuidl jaybuidl marked this pull request as ready for review December 27, 2023 18:05
@jaybuidl jaybuidl changed the title Fix: staking miscalculation + test coverage Fix: staking miscalculation + test coverage + devnet redeploy Dec 27, 2023
@jaybuidl jaybuidl merged commit 9c1ef81 into dev Dec 27, 2023
@jaybuidl jaybuidl deleted the fix/staking branch December 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants