Testnet banner #1360
Merged
Testnet banner #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alcercu
suggested changes
Dec 12, 2023
web/src/layout/Header/index.tsx
Outdated
| <Container> | ||
| <DesktopHeader /> | ||
| <MobileHeader /> | ||
| {process.env.REACT_APP_DEPLOYMENT === "testnet" && <Banner />} |
Contributor
There was a problem hiding this comment.
I think I would change the name from Banner to TestnetBanner
alcercu
suggested changes
Dec 12, 2023
web/src/layout/Header/index.tsx
Outdated
| <Container> | ||
| <DesktopHeader /> | ||
| <MobileHeader /> | ||
| {process.env.REACT_APP_DEPLOYMENT === "testnet" && <TestnetBanner />} |
Contributor
There was a problem hiding this comment.
sorry I forgot to mention it in the previous comment, let's switch this to the ternary operator too
Suggested change
| {process.env.REACT_APP_DEPLOYMENT === "testnet" && <TestnetBanner />} | |
| {process.env.REACT_APP_DEPLOYMENT === "testnet" ? <TestnetBanner /> : null} |
|
Code Climate has analyzed commit 7451435 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Contributor
|
closes #1358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1358
PR-Codex overview
Detailed summary
TestnetBannerto display a banner for testnet release.Headercomponent to conditionally render theTestnetBannerbased on theREACT_APP_DEPLOYMENTenvironment variable.HeaderContainerto wrap theDesktopHeaderandMobileHeadercomponents in theHeadercomponent.Containercomponent in theHeadercomponent.Wrapperto wrap theContainercomponent in theNavBarcomponent.Containercomponent in theNavBarcomponent.