Skip to content

Conversation

@kemuru
Copy link
Contributor

@kemuru kemuru commented Nov 22, 2023

closes #1208

after investigating, we were actually only voting up to 100 voteIDs. so the frontend value was displaying it correctly.
I could've put first: 512 instead but It doesn't hurt to put the maximum and forget about it


PR-Codex overview

Focus of the PR:

This PR focuses on modifying the useDrawQuery hook in the web/src/hooks/queries directory to fetch the first 1000 draws instead of all draws.

Detailed summary:

  • Modified the draws query in the useDrawQuery hook to fetch the first 1000 draws instead of all draws.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 2a0dbf2
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/655d5dc61e6b8800080d6551
😎 Deploy Preview https://deploy-preview-1339--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru requested a review from alcercu November 22, 2023 01:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 2a0dbf2 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 7ddf34f Nov 22, 2023
@jaybuidl jaybuidl added this to the testnet-2.1 milestone Nov 22, 2023
@jaybuidl jaybuidl deleted the fix(web)/increase-draw-query-results branch November 22, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web: possible bug? Voting limited to 100 votes?

4 participants