ffmpeg and ffpyplayer improvements #2335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing of GPL components if not necessary. Add support for x86 build in ffmmpeg recipe
Member
Author
|
Relates to matham/ffpyplayer#100 |
Contributor
|
Hello! I've tried and it seems to compile ok, also successfully checked on couple of videos. |
Member
Author
|
@germn can you create a dedicated PR for updating shine and x264 recipes please? |
Member
Author
|
@AndreMiras @inclement @matham Are there any objections left on this PR? would be great if it can be merged, thanks. |
AndreMiras
approved these changes
Dec 7, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, thanks for the reminder @rnixx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions of ffmpeg and ffpyplayer recipes.
Do not enable building of GPL components if not necessary.
Add support for x86 build in ffmpeg recipe