Call cython via the setuptools entrypoint, fixes #2311 #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclement
approved these changes
Sep 11, 2020
Member
inclement
left a comment
inclement
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks! I won't merge just yet in case someone else has an opinion, but the tests have passed so it should be fine.
Member
|
Thanks for the PR. I also have nothing against it and test suite is happy |
AndreMiras
approved these changes
Sep 11, 2020
vesellov
pushed a commit
to vesellov/python-for-android
that referenced
this pull request
Feb 10, 2021
germn
pushed a commit
to germn/python-for-android
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2311, the. running
python -m Cython.Build.Cythonizeis not the same thing as runningcython