Fix corner case of pip hack workaround we should get rid of anyway #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just an adjustment for our workaround for pypa/pip#6097 to fix a corner case. (The affected corner case was added to the unit test!) So this code should really be thrown out once pip fixes that issue
inclement
approved these changes
May 12, 2019
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an adjustment for the workaround for
pypa/pip#6097 to fix a corner case.
(The affected corner case was added to the unit test!)
So this code should really be thrown out once pip fixes that issue (so if we're wondering "should we even be dealing with this corner case?" - no, we shouldn't, pip should but sadly right now it doesn't)
Also I had this small fix lying around before #1625 was merged but forgot to include it 🤦♀️ 🤦♀️ 🤦♀️ lol