containsf revisited #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinbiko
force-pushed
the
implement-containsf-revisited
branch
from
56580f8 to
e30b006
Compare
kinbiko
force-pushed
the
implement-containsf-revisited
branch
from
e30b006 to
67a29ac
Compare
kinbiko
commented
Jun 24, 2023
| // Currently, in the case of "Containsf" there's an implicit "<<UNORDERED>>" (if it's explicitly written it will be ignored) | ||
| // This is so that nested arrays don't have to repeatedly say "<<UNORDERED">> assuming the user just wants to check for the existence of some element of an array. | ||
| // However, this makes jsonassert useless for cases where you want to partially assert that an ordered array exists. | ||
| // Ideally this package should be able to support both nicely. |
There was a problem hiding this comment.
Idea 1
Assertf: Implicit"<<ORDERED>>", explicit"<<UNORDERED>>"Containsf: Implicit"<<UNORDERED>>", explicit"<<ORDERED>>"
When *f is called with an implicit directive it is ignored.
When *f is called with an explicit directive it applies on only that array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to do #40 again, but with an up-to-date branch.
Discovered a key design issue I'd want to design around instead of accept any compromise.
Checklist