-
Notifications
You must be signed in to change notification settings - Fork 6
Remve dim parameter from AbstractDim #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 92.07% 91.74% -0.34%
==========================================
Files 11 12 +1
Lines 404 436 +32
==========================================
+ Hits 372 400 +28
- Misses 32 36 +4
Continue to review full report at Codecov.
|
Seems to be type stable:
|
Though this would mean that the dimension is not available at compile time anymore I think. Perhaps fixable by defining getdim(::Type{UniaxialStrain}) = 1 and so on? |
Hmm, if I remember correctly it everything was type-stable. Maybe because it is a singleton? I can double check |
What would I use for generic 2D cases that are neither plane strain nor plane stress now (like 2D cohesive elements)? |
It is a bit cleaner like this I think :)