-
Notifications
You must be signed in to change notification settings - Fork 14
Update KCIDB tests grouping #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
354dc64
to
c080a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change the jinja template as well. The new/fixed/unstable issues are destructured there and so you'll need to add another for
layer in order for the status to be properly shown.
Also please rebase, we have fixed the integration test that was causing an error and we also had some changes in the checkout summary that could conflict with yours |
Update `kcidb_test_results` to fetch architecture and compiler information for tests. Signed-off-by: Jeny Sadadia <[email protected]>
f608969
to
455e8c0
Compare
455e8c0
to
604b2af
Compare
backend/kernelCI_app/management/commands/templates/summary.txt.j2
Outdated
Show resolved
Hide resolved
604b2af
to
d150edd
Compare
Take architecture and compiler into account while grouping tests in `evaluate_test_results`. Signed-off-by: Jeny Sadadia <[email protected]>
d150edd
to
1c1e874
Compare
backend/kernelCI_app/management/commands/templates/summary.txt.j2
Outdated
Show resolved
Hide resolved
1c1e874
to
90b9e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working, but I think that the final result is not the best looking. It shows the config for every test, and seems to group tests by architecture even though the first parameter is the config.
IMO we could place the config_name above arch/compiler and add more spaces to group arch/compiler under configs, and then tests under arch/compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example above, it would mean:
Hardware: mt8395-genio-1200-evk
Config: defconfig+lab-setup+kselftest
- Architecture/compiler: arm64/gcc-12
- boot
last run: https://d.kernelci.org/test/maestro:68b7e1f7b9811ea53d01b575
history: > ✅ > ✅ > ❌ > ✅ >
Config: defconfig+preempt_rt
- Architecture/compiler: arm64/gcc-12
- rt-tests.cyclicdeadline
last run: https://d.kernelci.org/test/maestro:68b79c4eb9811ea53d016421
history: > ✅ > ⚠️
- rt-tests.cyclictest
last run: https://d.kernelci.org/test/maestro:68b79c53b9811ea53d016440
history: > ✅ > ⚠️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the testing. I fixed the summary template.
Tested OK locally. Thanks for helping me with the local setup @MarceloRobert :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @padovan
Does this structure look OK or do you need any changes? #1453 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about add one more level of indent
Hardware:
> Config:
- Arch/compiler:
So it reads better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about add one more level of indent
Hardware:
> Config:
- Arch/compiler:
So it reads better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Updated it.
Hardware: sun50i-h5-libretech-all-h3-cc
> Config: defconfig+arm64-chromebook+kselftest
- Architecture/compiler: arm64/gcc-12
- kselftest.uevent
last run: https://d.kernelci.org/test/maestro:68be1e3f3273d911562c70a2
history: > ✅ > ❌ > ✅ > ✅ > ✅
- kselftest.uevent.uevent_uevent_filtering
last run: https://d.kernelci.org/test/maestro:68be330a3273d911562cd016
history: > ✅ > ❌ > ✅ > ✅ > ✅
- kselftest.uevent.uevent_uevent_filtering_global_uevent_filtering
last run: https://d.kernelci.org/test/maestro:68be330a3273d911562cd017
history: > ✅ > ❌ > ✅ > ✅ > ✅
90b9e78
to
de9719f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working and looking good! I won't merge it, you can wait for Padovan's check and merge it later or you can do so now, you have the permission
Update `render_issues` macro to take into account `arch/compiler` string while iterating over issues for displaying checkout summary. Signed-off-by: Jeny Sadadia <[email protected]>
Update `RegressionData` model to accommodate newly added `arch/compiler` string. Signed-off-by: Jeny Sadadia <[email protected]>
de9719f
to
d63a5fc
Compare
Merging this one as all the comments have been addressed. |
kcidb_test_results
to fetch architecture and compiler information for testsevaluate_test_results