Remove use of current->cgns in bpf_cgroup_from_id #9449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fa47913 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2a0e5cd to
2562e0e
Compare
|
Upstream branch: 9e293d4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990210=>bpf-next
branch
from
cc06450 to
790159b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2562e0e to
5583eb6
Compare
|
Upstream branch: 3e2b799 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990210=>bpf-next
branch
from
790159b to
8ea0e96
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5583eb6 to
601ea2d
Compare
|
Upstream branch: c93c59b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990210=>bpf-next
branch
from
8ea0e96 to
16c9ccc
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
601ea2d to
7390c2c
Compare
The bpf_cgroup_from_id kfunc relies on cgroup_get_from_id to obtain the cgroup corresponding to a given cgroup ID. This helper can be called in a lot of contexts where the current thread can be random. A recent example was its use in sched_ext's ops.tick(), to obtain the root cgroup pointer. Since the current task can be whatever random user space task preempted by the timer tick, this makes the behavior of the helper unreliable. Resolve this by refactoring cgroup_get_from_id to take a parameter to elide the cgroup_is_descendant check when root_cgns parameter is set to true. There is no compatibility breakage here, since changing the namespace against which the lookup is being done to the root cgroup namespace only permits a wider set of lookups to succeed now. The cgroup IDs across namespaces are globally unique, and thus don't need to be retranslated. Reported-by: Dan Schatzberg <[email protected]> Acked-by: Tejun Heo <[email protected]> Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>
|
Upstream branch: bf0c2a8 |
Make sure that we only switch the cgroup namespace and enter a new cgroup in a child process separate from test_progs, to not mess up the environment for subsequent tests. Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990210=>bpf-next
branch
from
16c9ccc to
a31133a
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=990210 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Remove use of current->cgns in bpf_cgroup_from_id
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=990210