bpf: Don't use %pK through printk #9443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fa47913 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2a0e5cd to
2562e0e
Compare
|
Upstream branch: 9e293d4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990010=>bpf-next
branch
from
3d93f2c to
9ab4fc6
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2562e0e to
5583eb6
Compare
|
Upstream branch: 3e2b799 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990010=>bpf-next
branch
from
9ab4fc6 to
6128680
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5583eb6 to
601ea2d
Compare
|
Upstream branch: c93c59b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990010=>bpf-next
branch
from
6128680 to
2a14964
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
601ea2d to
7390c2c
Compare
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping locks in atomic contexts. Switch to the regular pointer formatting which is safer and easier to reason about. Signed-off-by: Thomas Weißschuh <[email protected]>
|
Upstream branch: bf0c2a8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990010=>bpf-next
branch
from
2a14964 to
1bc0e39
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7390c2c to
3a736b5
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=990010 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Don't use %pK through printk
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=990010