Skip to content

Conversation

@gabrieldemarmiesse
Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse commented Sep 14, 2018

Summary

I believe that it will be simpler to merge #8296 by breaking it down into indépendant, small PRs as much as possible. Here is the first one.

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@farizrahman4u farizrahman4u merged commit 842d360 into keras-team:master Sep 14, 2018
@farizrahman4u
Copy link
Contributor

If there is some git magic we could do to assign commits to the original author for upcoming PRs that would be great.

@gabrieldemarmiesse
Copy link
Contributor Author

Indeed, that'd be nice! Do you know how to? I can try to look it up.

@gabrieldemarmiesse
Copy link
Contributor Author

I just found how. git commit --author="Author Name <[email protected]>". I'll do it for the next commits.

@fchollet
Copy link
Collaborator

Please keep in mind that I should approve all API changes before merging (which this PR includes).

@gabrieldemarmiesse gabrieldemarmiesse deleted the attention_api_1 branch November 7, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants