Skip to content

Implement reset method in GitDataCollector #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2018
Merged

Implement reset method in GitDataCollector #20

merged 1 commit into from
Jan 8, 2018

Conversation

@stephanvierkant
Copy link
Contributor

@stephanvierkant stephanvierkant commented Dec 4, 2017

Fixes

User Deprecated: Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the "reset()" method is deprecated since version 3.4 and will be unsupported in 4.0 for class "Kendrick\SymfonyDebugToolbarGit\DataCollector\GitDataCollector".

@mediafigaro
Copy link
Contributor

mediafigaro commented Jan 8, 2018

thanks !

@kendrick-k kendrick-k merged commit ef4aa09 into kendrick-k:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mediafigaro mediafigaro mediafigaro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanvierkant @mediafigaro @kendrick-k