Skip to content

fix(demojify): Do not remove U+0023 # Number Sign #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2023
Merged

fix(demojify): Do not remove U+0023 # Number Sign #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25907ba
fix(demojify): Do not remove U+0023 # Number Sign
mikesmithgh Sep 12, 2023
adc3e00
chore: fix para test #
mikesmithgh Sep 13, 2023
11e053c
chore: update demojify test to include # comment
mikesmithgh Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Demojify.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ local blockedSingles = lookupify({
0x00023F8,
0x00023F9,
0x00023FA,
0x0000023,
0x0001F51F,
-- unicode 8
0x0001F6CC,
Expand Down
24 changes: 22 additions & 2 deletions test/demojify.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
@testset "demojify" begin
doc = test_pandoc("Hello world :wave:"; demojify = true)
doc = test_pandoc("""
Hello world :wave:

```sh
echo 😎cool # comment
```
"""; demojify = true)

@test """
*test.txt* Test Description
Expand All @@ -9,12 +15,22 @@ Table of Contents *test-table-of-contents*

Hello world

>sh
echo cool # comment
<

Generated by panvimdoc <https://github.com/kdheepak/panvimdoc>

vim:tw=78:ts=8:noet:ft=help:norl:
""" == doc

doc = test_pandoc("Hello world :wave:"; demojify = false)
doc = test_pandoc("""
Hello world :wave:

```sh
echo 😎cool # comment
```
"""; demojify = false)

@test """
*test.txt* Test Description
Expand All @@ -24,6 +40,10 @@ Table of Contents *test-table-of-contents*

Hello world :wave:

>sh
echo 😎cool # comment
<

Generated by panvimdoc <https://github.com/kdheepak/panvimdoc>

vim:tw=78:ts=8:noet:ft=help:norl:
Expand Down
2 changes: 1 addition & 1 deletion test/para.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ All of the content in curly braces `{...}` that is part of the header is dropped
*test.txt* Test Description

Pandoc supports definition lists:
<https://pandoc.org/MANUAL.htmldefinition-lists>. This can be used to generate
<https://pandoc.org/MANUAL.html#definition-lists>. This can be used to generate
documentation of mappings. All of the content in curly braces `{...}` that is
part of the header is dropped and a tag is created.

Expand Down