Hard-coded native attributes

.github/workflows/test-turbo.yml

@@ -17,20 +17,9 @@ jobs:
                   php-version: '8.0'
                   extensions: zip
 
-            - name: Get composer cache directory
-              id: composercache
-              run: echo "::set-output name=dir::$(composer config cache-files-dir)"
-
-            - name: Cache dependencies
-              uses: actions/cache@v2
+            - uses: ramsey/composer-install@v2
               with:
-                  path: ${{ steps.composercache.outputs.dir }}
-                  key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
-                  restore-keys: ${{ runner.os }}-composer-
-
-            - name: Install dependencies
-              working-directory: src/Turbo
-              run: composer install --prefer-dist
+                  working-directory: src/Turbo
 
             - name: Install PHPUnit dependencies
               working-directory: src/Turbo
@@ -71,20 +60,9 @@ jobs:
                   php-version: ${{ matrix.php-versions }}
                   extensions: zip, pdo_sqlite
 
-            - name: Get composer cache directory
-              id: composercache
-              run: echo "::set-output name=dir::$(composer config cache-files-dir)"
-
-            - name: Cache PHP dependencies
-              uses: actions/cache@v2
+            - uses: ramsey/composer-install@v2
               with:
-                  path: ${{ steps.composercache.outputs.dir }}
-                  key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
-                  restore-keys: ${{ runner.os }}-composer-
-
-            - name: Install PHP dependencies
-              working-directory: src/Turbo
-              run: composer install --prefer-dist
+                  working-directory: src/Turbo
 
             - name: Get yarn cache directory path
               id: yarn-cache-dir-path
@@ -143,20 +121,10 @@ jobs:
                   php-version: '8.0'
                   extensions: zip, pdo_sqlite
 
-            - name: Get composer cache directory
-              id: composercache
-              run: echo "::set-output name=dir::$(composer config cache-files-dir)"
-
-            - name: Cache PHP dependencies
-              uses: actions/cache@v2
+            - uses: ramsey/composer-install@v2
               with:
-                  path: ${{ steps.composercache.outputs.dir }}
-                  key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
-                  restore-keys: ${{ runner.os }}-composer-
-
-            - name: Install PHP dependencies
-              working-directory: src/Turbo
-              run: composer update --prefer-dist --prefer-lowest --prefer-stable
+                  working-directory: src/Turbo
+                  dependency-versions: lowest
 
             - name: Get yarn cache directory path
               id: yarn-cache-dir-path

.github/workflows/test.yaml

@@ -18,37 +18,88 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@master
+            - name: Get yarn cache directory path
+              id: yarn-cache-dir-path
+              run: echo "::set-output name=dir::$(yarn cache dir)"
+            - uses: actions/cache@v2
+              id: yarn-cache
+              with:
+                  path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+                  key: ${{ runner.os }}-yarn-${{ hashFiles('**/package.json') }}
+                  restore-keys: |
+                      ${{ runner.os }}-yarn-
             - run: yarn
             - run: yarn check-lint
             - run: yarn check-format
 
+    js-dist-current:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@master
+            - name: Get yarn cache directory path
+              id: yarn-cache-dir-path
+              run: echo "::set-output name=dir::$(yarn cache dir)"
+            - uses: actions/cache@v2
+              id: yarn-cache
+              with:
+                  path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+                  key: ${{ runner.os }}-yarn-${{ hashFiles('**/package.json') }}
+                  restore-keys: |
+                      ${{ runner.os }}-yarn-
+            - run: yarn && yarn build
+            - name: Check if js dist files are current
+              id: changes
+              uses: UnicornGlobal/[email protected]
+
+            - name: Ensure no changes
+              if: steps.changes.outputs.changed == 1
+              run: |
+                echo "JS dist files need to be rebuilt"
+                exit 1
+
     tests-php-low-deps:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@master
             - uses: shivammathur/setup-php@v2
               with:
                   php-version: '7.2'
-            - name: Chartjs
-              run: |
-                  cd src/Chartjs
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: Cropperjs
-              run: |
-                  cd src/Cropperjs
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: Dropzone
-              run: |
-                  cd src/Dropzone
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: LazyImage
-              run: |
-                  cd src/LazyImage
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
+
+            - name: Chartjs Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Chartjs
+                  dependency-versions: lowest
+            - name: Chartjs Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Chartjs
+
+            - name: Cropperjs Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Cropperjs
+                  dependency-versions: lowest
+            - name: Cropperjs Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Cropperjs
+
+            - name: Dropzone Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Dropzone
+                  dependency-versions: lowest
+            - name: Dropzone Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Dropzone
+
+            - name: LazyImage Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/LazyImage
+                  dependency-versions: lowest
+            - name: LazyImage Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/LazyImage
 
     tests-php8-low-deps:
         runs-on: ubuntu-latest
@@ -57,17 +108,25 @@ jobs:
             - uses: shivammathur/setup-php@v2
               with:
                   php-version: '8.0'
-            - name: TwigComponent
-              run: |
-                  cd src/TwigComponent
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: LiveComponent
-              run: |
-                  cd src/LiveComponent
-                  php ../../.github/build-packages.php
-                  composer update --prefer-lowest --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
+            - run: php .github/build-packages.php
+
+            - name: TwigComponent Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/TwigComponent
+                  dependency-versions: lowest
+            - name: TwigComponent Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/TwigComponent
+
+            - name: LiveComponent Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/LiveComponent
+                  dependency-versions: lowest
+            - name: LiveComponent Tests
+              working-directory: src/LiveComponent
+              run: php vendor/bin/simple-phpunit
 
     tests-php-high-deps:
         runs-on: ubuntu-latest
@@ -76,41 +135,69 @@ jobs:
             - uses: shivammathur/setup-php@v2
               with:
                   php-version: '8.0'
-            - name: Chartjs
-              run: |
-                  cd src/Chartjs
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: Cropperjs
-              run: |
-                  cd src/Cropperjs
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: Dropzone
-              run: |
-                  cd src/Dropzone
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: LazyImage
-              run: |
-                  cd src/LazyImage
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: TwigComponent
-              run: |
-                  cd src/TwigComponent
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
-            - name: LiveComponent
-              run: |
-                  cd src/LiveComponent
-                  php ../../.github/build-packages.php
-                  composer update --prefer-dist --no-interaction --no-ansi --no-progress
-                  php vendor/bin/simple-phpunit
+            - run: php .github/build-packages.php
+
+            - name: Chartjs Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Chartjs
+            - name: Chartjs Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Chartjs
+
+            - name: Cropperjs Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Cropperjs
+            - name: Cropperjs Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Cropperjs
+
+            - name: Dropzone Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/Dropzone
+            - name: Dropzone Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/Dropzone
+
+            - name: LazyImage Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/LazyImage
+            - name: LazyImage Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/LazyImage
+
+            - name: TwigComponent Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/TwigComponent
+            - name: TwigComponent Tests
+              run: php vendor/bin/simple-phpunit
+              working-directory: src/TwigComponent
+
+            - name: LiveComponent Dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  working-directory: src/LiveComponent
+            - name: LiveComponent Tests
+              working-directory: src/LiveComponent
+              run: php vendor/bin/simple-phpunit
 
     tests-js:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@master
+            - name: Get yarn cache directory path
+              id: yarn-cache-dir-path
+              run: echo "::set-output name=dir::$(yarn cache dir)"
+            - uses: actions/cache@v2
+              id: yarn-cache
+              with:
+                  path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+                  key: ${{ runner.os }}-yarn-${{ hashFiles('**/package.json') }}
+                  restore-keys: |
+                      ${{ runner.os }}-yarn-
             - run: yarn
             - run: yarn test

.php-cs-fixer.dist.php

@@ -24,6 +24,7 @@
             ->append([__FILE__])
             ->notPath('#/Fixtures/#')
             ->notPath('#/app/var/#')
+            ->notPath('#/var/cache/#')
             ->notPath('Turbo/Attribute/Broadcast.php') // Need https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4702
     )
 ;

package.json

@@ -45,7 +45,8 @@
             "plugin:@typescript-eslint/recommended"
         ],
         "rules": {
-            "@typescript-eslint/no-explicit-any": "off"
+            "@typescript-eslint/no-explicit-any": "off",
+            "@typescript-eslint/no-empty-function": "off"
         },
         "env": {
             "browser": true

src/Dropzone/Resources/assets/dist/controller.js

@@ -43,7 +43,7 @@ class default_1 extends Controller {
         });
         reader.readAsDataURL(file);
     }
-    _dispatchEvent(name, payload) {
+    _dispatchEvent(name, payload = {}) {
         this.element.dispatchEvent(new CustomEvent(name, { detail: payload }));
     }
 }

src/LazyImage/Resources/assets/dist/controller.js

@@ -3,11 +3,12 @@ import { Controller } from '@hotwired/stimulus';
 class default_1 extends Controller {
     connect() {
         const hd = new Image();
+        const element = this.element;
         const srcsetString = this._calculateSrcsetString();
         hd.addEventListener('load', () => {
-            this.element.src = this.srcValue;
+            element.src = this.srcValue;
             if (srcsetString) {
-                this.element.srcset = srcsetString;
+                element.srcset = srcsetString;
             }
             this._dispatchEvent('lazy-image:ready', { image: hd });
         });

src/LiveComponent/CHANGELOG.md

@@ -2,10 +2,23 @@
 
 ## 2.1.0
 
+-   Your component's live "data" is now send over Ajax as a JSON string.
+    Previously data was sent as pure query parameters or as pure POST data.
+    However, this made it impossible to keep certain data types, like
+    distinguishing between `null` and `''`. This has no impact on end-users.
+
+-   Added `data-live-ignore` attribute. If included in an element, that element
+    will not be updated on re-render.
+
+-   `ComponentWithFormTrait` no longer has a `setForm()` method. But there
+    is also no need to call it anymore. To pass an already-built form to
+    your component, pass it as a `form` var to `component()`. If you have
+    a custom `mount()`, you no longer need to call `setForm()` or anything else.
+
 -   The Live Component AJAX endpoints now return HTML in all situations
     instead of JSON.
 
--   Send live action arguments to backend
+-   Ability to send live action arguments to backend
 
 -   [BC BREAK] Remove `init_live_component()` twig function, use `{{ attributes }}` instead:
     ```diff