feat(wip): support latest versions of kafka protocol #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
force-pushed
the
bump-kafka-clients-to-4.1
branch
from
6843b45 to
f4ba128
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 80.03% 78.19% -1.84%
==========================================
Files 21 21
Lines 1703 2064 +361
==========================================
+ Hits 1363 1614 +251
- Misses 340 450 +110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zmstone
reviewed
Sep 20, 2025
| %% @end | ||
| %% Can not get dialyzer working for this call: | ||
| %% kpro_req_lib:metadata(Vsn, [Topic]) | ||
| -dialyzer([{nowarn_function, [discover_partition_leader/5]}]). |
There was a problem hiding this comment.
maybe see if dialyzer works fine now.
| %% @end | ||
| %% Can not get dialyzer working for this call: | ||
| %% kpro_req_lib:metadata(Vsn, [Topic]) | ||
| -dialyzer([{nowarn_function, [discover_partition_leader/4]}]). |
There was a problem hiding this comment.
maybe check if dialyzer works now
Comment on lines
+194
to
+198
| TopicId = | ||
| case Vsn of | ||
| V when V < 10 -> <<>>; | ||
| _ -> kpro:find(topic_id, TopicMeta) | ||
| end, |
There was a problem hiding this comment.
Suggested change
| TopicId = | |
| case Vsn of | |
| V when V < 10 -> <<>>; | |
| _ -> kpro:find(topic_id, TopicMeta) | |
| end, | |
| TopicId = kpro:find(topic_id, TopicMeta, <<>>) |
| ({_, V}) -> | ||
| Fields = [ {key, Id}, {key_type, Type}], | ||
| {ok, kpro:make_request(find_coordinator, V, Fields)} | ||
| ({_, V}) when V < 4 -> |
| {rack_id, RackID} | ||
| ], | ||
| make(fetch, Vsn, Fields). | ||
| MaxWaitTime = maps:get(max_wait_time, Opts, timer:seconds(1)), |
There was a problem hiding this comment.
indentation in this repo is 2, new code has 4
please try to keep the style unchanged.
| end, | ||
| Fields = | ||
| case Vsn of | ||
| V when V < 10 -> |
| case get_api_vsn_range(Connection, find_coordinator) of | ||
| {error, Reason} -> | ||
| {error, Reason}; | ||
| {ok, {_, V}} when V < 4 -> |
zmstone
reviewed
Sep 20, 2025
| %% Can not get dialyzer working for this call: | ||
| %% kpro_req_lib:metadata(Vsn, [Topic]) | ||
| -dialyzer([{nowarn_function, [discover_partition_leader/5]}]). | ||
| -spec discover_partition_leader(connection(), topic(), partition(), |
There was a problem hiding this comment.
add a comment or variable name for the last arg ReturnTopicId :: boolean() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.