Skip to content

Conversation

@jw3126
Copy link
Owner

@jw3126 jw3126 commented Oct 1, 2019

No description provided.

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@tkf Do you know why CI fails? Locally I can ]add ConstructionBase just fine. Does Travis some magic caching?

@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

I think it's working https://travis-ci.org/jw3126/Setfield.jl/builds/595455069 (click continuous-integration/travis-ci/pr above the merge button)? If you are looking at continuous-integration/travis-ci/push, that's the CI for this branch as-is built when you pushed, different from the one you can restart via close-then-open.

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

Ah I see, thanks for explaining.

@jw3126 jw3126 merged commit 5329d33 into master Oct 9, 2019
@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

image

You can also click this right-top Restart build button.

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@tkf I would like to tag a release, any objections?

@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

I think it's good to go. FYI, testing Kaleido with Setfield 0.5 worked: tkf/Kaleido.jl#8

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants