Remove type parameters from == methods of IndexLens and CompositeLens #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Yeah to me it is a bug fix, but the interpretation that this changes behavior of equality is also valid. I don't feel strongly, but since we need a decision, let's make it a patch release. |
jw3126
approved these changes
Nov 22, 2021
Owner
jw3126
left a comment
jw3126
left a comment
There was a problem hiding this comment.
LGTM! Just needs a version bump as discussed above. Thanks @phipsgabler !
Owner
|
Thanks and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
I'm not quite sure whether this is considered breaking; it changes behaviour of equality for some of the methods...?