Skip to content

리팩토링: 인터페이스, 일급컬렉션, 테스트코드 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: test/validator-and-indicator
Choose a base branch
from
Open

리팩토링: 인터페이스, 일급컬렉션, 테스트코드 #2

wants to merge 3 commits into from

Conversation

@chs1234
Copy link
Contributor

@chs1234 chs1234 commented Apr 29, 2023 •
edited
Loading

summary

  • Cars 일급 컬렉션 포장(RacingCars)
  • 인터페이스/구현체 개발
  • 도메인 모델 별로 테스트 코드 추가

@chs1234 chs1234 requested review from dongKos and wapago April 29, 2023 15:38
@dongKos
Copy link

dongKos commented Apr 30, 2023 •
edited
Loading

@chs1234
요거 test/validator-and-indicator 브랜치에서 딴거야? 그렇다면 베이스 브랜치를 바꿔주셈

dongKos
dongKos approved these changes Apr 30, 2023
View reviewed changes
Copy link

@dongKos dongKos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

build.gradle Outdated
implementation 'org.projectlombok:lombok:1.18.22'
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.1'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.1'
testImplementation 'org.junit.jupiter:junit-jupiter-params:5.4.2'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bom 씁시다! bom에 다 있습니다!
스크린샷 2023-04-30 오전 9 31 31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마침 또 봄이 찾아왔으니 bom을 써야겠구만 😏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongKos
봄이다 봄..ㅎ

src/test/java/model/CarsTest.java
class CarsTest {

@ParameterizedTest
@MethodSource("invalidParameters")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 이런게 있군요

@chs1234 chs1234 changed the base branch from main to test/validator-and-indicator April 30, 2023 02:53
wapago
wapago approved these changes May 30, 2023
View reviewed changes
Copy link

@wapago wapago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongKos dongKos dongKos approved these changes

@wapago wapago wapago approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chs1234 @dongKos @wapago