-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Adding Attach button #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Related to #103 |
Thanks @nakul-py for working on this! Wondering if we will also be available to leverage the change that was recently merged in |
Thanks @nakul-py. First, I really like the UI of the file selector, maybe something similar could be ported upstream in Jupyterlab, instead of the current file selector. About the current PR, I'm not sure about the user experience of it, since you have to “send” the message once to display the file dialog, and then send it again after selecting the file. jupyter-chat already provides an Do you think that we should/could take advantage of the existing UI/UX of |
Yes we can use the |
Hey @brichet I am happy to contribute to JupyterLab, but as I am new to JupyterLab, I want your guidance. |
Thanks again @nakul-py for working on this.
Did you try to add the |
4e72234
to
b38057a
Compare
Now it's done with IDocumentManager and help me if you want better Filebrowser UI and where in ( |
@nakul-py thanks again for working on this and updating the PR quickly. |
Thanks, this looks good. I wonder now what should we do with that attachment, currently it is not used when sending the message. We should probably send the file content (and name/path probably) with the message, for the LLM to be able to access it. It could be an additional message when the attachment is provided. Since the file content can be huge (and use a lot of token), I would suggest making this attachment as optional in the settings (default to not used for now), with a warning about the amount of data that can be sent. |
@brichet How this looks. Screencast.From.2025-07-24.17-30-15.mp4 |
Add a new Attach button that opens a file browser slider to select and inject file paths into the chat input.
Screencast.From.2025-07-18.17-01-09.mp4
Closes #103