-
Notifications
You must be signed in to change notification settings - Fork 367
Try to fix failing ci on pr 1417 #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HaudinFlorence
wants to merge
7
commits into
jupyterlab:main
Choose a base branch
from
HaudinFlorence:try_to_fix_failing_CI_on_PR_1417
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Try to fix failing ci on pr 1417 #1426
HaudinFlorence
wants to merge
7
commits into
jupyterlab:main
from
HaudinFlorence:try_to_fix_failing_CI_on_PR_1417
+81
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be5345a
to
c29b4df
Compare
71bceb4
to
0e6f469
Compare
0caa013
to
b843590
Compare
CI is green. Not sure if the fixes proposed are ok. Comments are welcome. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a superseed of PR #1417
It is trying to fix the failing tests.