-
Notifications
You must be signed in to change notification settings - Fork 150
Adopt hatchling, plugins for python package build #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"jupyter_server_proxy/labextension", | ||
] | ||
exclude = [ | ||
".git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey! just FYI this is always excluded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you soo much for your work on this @bollwyvl!!!
Overall this LGTM but there was some changes I wished for with associated code suggestions.
- Removal of
set -eux
- Removal of cache for python packages (but not for installing yarn.lock)
- Revert addition of
jupyter-server-proxy[docs]
as a pip install target
I think `-e` to error early and `-x` to print statements is the default in a github actions runner already. The addition of `-u` to error on using unset environment variables is the addtion I think isn't a default. If we need a stricter shell script execution, we can use `defaults.run`, see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defaultsrun.
In doing this, I'd recommend as well that we add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the final comment, this LGTM!
Do you consider this ready for merge as well at this point @bollwyvl?
Yes, I've no further changes planned once it passes CI.
I'll change this to just use |
Publish is passing, so this is probably good. Happy to make any other fixes, or let others do so... feel free to squash merge. |
Wiee nice thank you @bollwyvl!!! Super happy about this being modernized!! I went for a normal merge as I think a few jupyterhub team members prefer we use that consistently. |
References
Elevator Pitch
hatchling
and some plugins:hatch-jupyter-builder
handles thejlpm
junkhatch-nodejs-version
fetches metadata frompackage.json
etc
folders with their destination structure