Skip to content

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jan 14, 2021

This fixes a bug. When user want's to shutdown the notebook server without confirmation, they should be able to call:

jupyter notebook -y

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @afshin!

The failing test is unrelated. Merging away!

@Zsailer Zsailer merged commit f6966e4 into jupyter:master Jan 14, 2021
@Zsailer
Copy link
Member

Zsailer commented Jan 14, 2021

We'll want to port this to jupyter_server, too, to address jupyter-server/jupyter_server#383

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants