Skip to content

implement natural sorting fixes #5230 #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

implement natural sorting fixes #5230 #5259

wants to merge 2 commits into from

Conversation

@valsen
Copy link

@valsen valsen commented Feb 28, 2020

Co-authored-by: anthial [email protected]
Co-authored-by: AristotelisKotsias [email protected]
Co-authored-by: KirkEasterson [email protected]
Co-authored-by: christinasunnegardh [email protected]

@kevin-bates kevin-bates mentioned this pull request May 5, 2020
Closed
24 tasks
@blink1073 blink1073 added this to the 6.1 milestone May 15, 2020
christinasunnegardh and others added 2 commits May 15, 2020 18:09
@christinasunnegardh @Anthial
@AristotelisKotsias @KirkEasterson @afshin
implement natural sorting fixes jupyter#5230
4ccca5e 
Co-authored-by: anthial <[email protected]>
Co-authored-by: AristotelisKotsias <[email protected]>
Co-authored-by: KirkEasterson <[email protected]>
Co-authored-by: christinasunnegardh <[email protected]>
@valsen @afshin
eliminate change in whitespace jupyter#5230
f8ee6de
@afshin afshin force-pushed the natural_sorting branch from 8be36c8 to f8ee6de Compare May 15, 2020 17:09
afshin
afshin requested changes May 16, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you so much for the pull request! I checked out this branch to review. I rebased against the master branch to see if the test failures go away, but they still fail. Could you please take a look at the test failures in this branch?

@kevin-bates
Copy link
Member

kevin-bates commented Jul 23, 2020

@valsen - could someone from your team please look into the build failures. This feature may have to fall off the 6.1 wagon if the build issues are not addressed soon. Thank you.

@kevin-bates kevin-bates modified the milestones: 6.1, 6.2 Jul 31, 2020
@blink1073 blink1073 modified the milestones: 6.2, 6.3, 6.4 Mar 17, 2021
@jtpio
Copy link
Member

jtpio commented Aug 4, 2023

Closing as the classic notebook UI now lives in a different repo: https://github.com/jupyter/nbclassic.

Feel free to open a new issue on the JupyterLab if you it would still be useful to have this feature: https://github.com/jupyterlab/jupyterlab. That way it would also be available in Notebook 7.

Thanks!

@jtpio jtpio closed this Aug 4, 2023
@jtpio jtpio modified the milestones: 6.4, Reference Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@afshin afshin afshin requested changes

Assignees

@afshin afshin

Labels

None yet

Projects

None yet

Milestone

Reference

Development

Successfully merging this pull request may close these issues.

6 participants

@valsen @kevin-bates @jtpio @afshin @blink1073 @christinasunnegardh