Improve keyboard shortcut discoverability

[cogwheel]

IMO all programs with keyboard shortcuts should display them in menus or on hover tooltips. At least have this as a toggleable help option.

Right now the only way to see the keyboard shortcuts is to open a modal dialog on top of your notebook. If you really don't want to display keyboard shortcuts in the UI, then at least open this in a separate window or allow the window to float rather than block all other actions on the page.

[gnestor]

IMO all programs with keyboard shortcuts should display them in menus or on hover tooltips

I agree, the notebook should display keymaps inline in the menus. Most of our development bandwidth is focused on JupyterLab now so we don't have much bandwidth to add new features to the classic notebook. I'm going to mark this with "JupyterLab" and "New Contributor" meaning that this should be implemented in JupyterLab and that this would be a great opportunity for a new contributor.

@cogwheel If you would like to take a crack at this, I will gladly help and review your PR.

[cogwheel]

I appreciate the support for the suggestion. I would probably describe my current interest in Jupyter as exceedingly cursory to begin with (I have no planned use, just toying around), and that's with the Haskell kernel, not even Python. If Jupyter becomes a bigger part of my life before someone else gets to it, then we'll see :)

[aaronmyatt]

@gnestor the notebook.html template is easy enough to navigate. I can easily update each menu item with their corresponding keyboard shortcut, but this doesn't seem very intelligent!

I've discovered the Keyboard Shortcut dialog is generated. Perhaps I could utilise some of these utilities to dynamically populate the menu drop downs with platform specific keyboard that are exactly the same as those shown in the shortcut dialog:

Any advice regarding how to achieve this, or whether it is even a sensible approach, welcome!

[aaronmyatt]

Ok a fair degree of progress:

To achieve this I have extended the MenuBar object to also add the keybinding when it loops over the id_actions_dict.

It's ugly, and I'm pretty sure incomplete, but I'll be glad for early feedback.

[gnestor]

@aaronmyatt Looking good! Great start. Would you like to submit a PR so that we can collaborate on it?

[aaronmyatt]

@gnestor I would be glad to make a PR! I didn't think you would want one so soon, usually I am the lone proponent of early PRs in my company!

I'll double check the contributor guidelines and get a PR up asap.

[gnestor]

Early PRs are welcome 👍