Skip to content

Async subclasses #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2020
Merged

Async subclasses #528

merged 4 commits into from
Mar 5, 2020

Conversation

@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Mar 5, 2020

Reboot #428

@kevin-bates
Add support for async kernel management via subclassing
6c67f53 
Introduced async subclasses that derive from synchronous classes,
overriding appropriate methods with async support.
@kevin-bates
Convert to async/await model
f6f8696
@kevin-bates
Apply changes per review
86b8e72 
Also added the cache_ports logic that existed in the sync multiKernelManager.
@kevin-bates
Add async def is_alive() back
6beb0f9
@SylvainCorlay SylvainCorlay merged commit 4125fa4 into jupyter:master Mar 5, 2020
@SylvainCorlay SylvainCorlay deleted the async-subclasses branch March 5, 2020 14:54
@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Mar 5, 2020

@kevin-bates you should now be credited for your commits!

@kevin-bates
Copy link
Member

kevin-bates commented Mar 5, 2020

@SylvainCorlay - thank you.
@davidbrochart - thank you for the review and making the changes better. I look forward to working with you on future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SylvainCorlay @kevin-bates