handle classes having been torn down in atexit #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we could probably avoid this if we registered/unregistered atexit callbacks for instances instead of registering it once for classes at import time
Member
|
I'm happy enough with this simple but somewhat dirty approach. |
rgbkrk
approved these changes
Jan 17, 2018
takluyver
added a commit
that referenced
this pull request
Jan 17, 2018
Backport PR #336 on branch 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we could probably avoid this if we registered/unregistered atexit callbacks for instances instead of registering it once for classes at import time
closes #323
Perhaps more hygenic, if more complex alternative that would use instances:
__init____del__Attaching it to an instance should prevent any process-teardown issues, since classes don't get deleted while they still have running instances (I'm pretty sure).