Preserve document_id state when setting notebook source #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the
document_idstate that's used by Jupyter collaboration UI for server side execution mode.Currently in jupyter-collaboration, if an out of band change happens (eg. user edits the file in non-RTC mode), the server will attempt to revert the document in memory to the source here, which is also the case in Jupyverse.
It deletes
document_idin ystate and propagates it in an update to clients, to which they won't be able to execute cells anymore if server side execution mode is enabled, since they won't be able to provide adocument_idin the HTTP execution request body. They will have to refresh their tab and sync again, asdocument_idis actually set on sync.