Skip to content

Enable kernel message filtering #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2018
Merged

Enable kernel message filtering #22

merged 2 commits into from
Aug 6, 2018

Conversation

@SylvainCorlay
Copy link
Contributor

@SylvainCorlay SylvainCorlay commented Aug 6, 2018 •
edited
Loading

Fixes #17.

To change that parameter: first

jupyter server --generate-config

to generate a configuration file, then change the list of allowed message types.

c.MappingKernelManager.allowed_message_types = ['kernel_info_request']

will cause e.g. execute_request message to trigger the warning:

"Received message of type "kernel_info_request", which is not allowed. Ignoring."

blink1073
blink1073 approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SylvainCorlay SylvainCorlay changed the title Enable kernel message filtering WIP - Enable kernel message filtering Aug 6, 2018
@SylvainCorlay SylvainCorlay force-pushed the filter-message branch 2 times, most recently from b2ae5a0 to e11efaa Compare August 6, 2018 12:02
@SylvainCorlay SylvainCorlay force-pushed the filter-message branch 2 times, most recently from 5af2afd to 8898a19 Compare August 6, 2018 13:58
@SylvainCorlay SylvainCorlay merged commit e0f3c08 into jupyter-server:master Aug 6, 2018
@SylvainCorlay SylvainCorlay changed the title WIP - Enable kernel message filtering Enable kernel message filtering Aug 6, 2018
@SylvainCorlay SylvainCorlay deleted the filter-message branch August 6, 2018 16:22
@SylvainCorlay SylvainCorlay mentioned this pull request Nov 13, 2018
Merged
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
Merge pull request jupyter-server#22 from zsailer/mock
ff7f398 
Tests for Notebook Service Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SylvainCorlay @blink1073