Skip to content

Add a logger to the ExtensionPoint API #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Add a logger to the ExtensionPoint API #1523

merged 1 commit into from
Jul 25, 2025

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 12, 2025

Motivated by #1521.

Supercedes #1522.

Adds a logger to the ExtensionPoint API.

This is fully backwards compatible, so should be fairly easy to review and merge.

@Zsailer Zsailer mentioned this pull request May 12, 2025
Closed
@Abigayle-Mercer Abigayle-Mercer mentioned this pull request May 12, 2025
Draft
vidartf
vidartf approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine to me, because even if we want to switch to using something more similar to LoggingConfigurable in the future, it should still be the same trait/type.

@Zsailer Zsailer merged commit 9908848 into jupyter-server:main Jul 25, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidartf vidartf vidartf approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zsailer @vidartf