Skip to content

don't let ExtensionApp jpserver_extensions be overridden by config #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

don't let ExtensionApp jpserver_extensions be overridden by config #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jupyter_server/serverapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2724,7 +2724,11 @@ def initialize(
self._init_asyncio_patch()
# Parse command line, load ServerApp config files,
# and update ServerApp config.
# preserve jpserver_extensions, which may have been set by starter_extension
# don't let config clobber this value
jpserver_extensions = self.jpserver_extensions.copy()
super().initialize(argv=argv)
self.jpserver_extensions.update(jpserver_extensions)
if self._dispatching:
return
# initialize io loop as early as possible,
Expand Down