[Batch 5] Porting Notebook PRs #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Sep 27, 2019
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Thanks Zach. Had the one comment about selenium tests.
Could you also rebase against master since conflicts will prevent the merge?
This change will probably be needed for Tornado 6. Ben Darnell figured it out. https://groups.google.com/d/msg/python-tornado/mSeG7Kc6z4o/baeTDOvJGgAJ
Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts.
found by lgtm
Member
Author
|
Rebased. |
Member
|
No cleanup necessary. |
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* clean up JS tests * more cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting: