fixes #960: lazy import of launch_instance in top-level __init__.py #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… __init__.py - also removed redundant `"scripts"` field of `setup.py`
kevin-bates
approved these changes
May 3, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
These changes look good and appear to work fine - thank you for pointing this out Max!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960 by making the problem import lazy. Also removed redundant
"scripts"field fromsetup.py(noticed that since I had to make a small tweak to both that and"entry_points").If making the
launch_instanceimport lazy seems too convoluted, I think another valid fix would be to removelaunch_instancefrom the module top-level entirely. It's sufficient to be able to do: