Skip to content

Fix server doesn't initialize #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Fix server doesn't initialize #1313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4e58f0
Fix server doesn't initialize
jwortmann Aug 16, 2024
ba36759
Only normalize Windows paths starting with drive letter
jwortmann Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/requests/init.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,12 @@
file_full_path = joinpath(server.env_path, file)
uri = filepath2uri(file_full_path)
if isfile(file_full_path)
@static if Sys.iswindows()

Check warning on line 254 in src/requests/init.jl

View check run for this annotation

Codecov / codecov/patch

src/requests/init.jl#L254 

Added line #L254 was not covered by tests
# Normalize drive letter to lowercase
if length(file_full_path) > 1 && isletter(file_full_path[1]) && file_full_path[2] == ':'
file_full_path = lowercasefirst(file_full_path)

Check warning on line 257 in src/requests/init.jl

View check run for this annotation

Codecov / codecov/patch

src/requests/init.jl#L256-L257 

Added lines #L256 - L257 were not covered by tests
end
end
# Only add again if outside of the workspace folders
if all(i->!startswith(file_full_path, i), server.workspaceFolders)
if haskey(server._files_from_disc, uri)
Expand Down
Loading